- Status Closed
- Percent Complete
- Task Type Patches
- Category Music playback
- Assigned To No-one
- Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Release 3.6
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#11767 - Meier crossfeed
Attached patch adds a new crossfeed algorithm to rockbox, emulating the basic “Meier” crossfeed (2 capacitors, 3 resistors) as discussed in http://www.meier-audio.homepage.t-online.de/passivefilter.htm
This crossfeed blends a bit of low-pass filtered L signal into the R signal (and vice versa) while adding about 300 us delay to the crossfed-signal. A difference with the crossfeed already present in rockbox, is that this algorithm keeps the total spectrum flat (the one currently in rockbox accentuates low-frequency signals, making it sound a bit muffled).
This implementation is quite lightweight, just 3 multiplies per left-right pair of samples, but only has a C implementation right now (no asm).
The crossfeed effect is quite subtle and is noticeable mostly one albums that have very strong left-right separation (e.g. one instrument only on the left, another only on the right).
In the user interface, the new crossfeed option appears as “Meier” and is not configureable. The existing crossfeed is renamed to “Custom” as it allows itself to be customised.
There is no entry for the user manual yet.
meier_v3.patch
(7.3 KiB)
2012-05-01 08:27
Reason for closing: Out of Date
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407 Warning: Undefined array key "useheading" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 1099 Warning: Undefined array key "target" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557 Warning: Trying to access array offset on value of type null in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557
Synced to 0dd00b33 and moved to
gerrit.
http://gerrit.rockbox.org
/r/#/c/227/
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
Nice addition. I tested this patch on a few files, and I do indeed have the impression that it accomplishes its objective (crossfeed) without requiring configuration and while maintaining a better sound quality.
I tested this v3 patch with some “regular” and some very hard-panned music. It’s really rather subtle, and IMO the v2 of this patch had more beneficial effects while still maintaining good audio clarity. Would it be possible to keep the v2 version next to this v3 one, for example selectable as “Meier 1” and “Meier 2” in the menu?
I haven’t seen a v2 version of this patch anywhere. Does anyone of you still have that version lying around somewhere, and if so, could you please post it here?
In my view, the current Meier-crossfeed feature (v3 patch) is superior to Rockbox’s standard crossfeed feature (better sound quality, no configuration needed) and could actually replace it. I find it hard to imagine anyone actually fiddling with the plethora of crossfeed settings we have today.
V2 is the last post in
FS#11577.The only difference between v2 and v3 are two digits. In dsp.c replace both (0x7fffffff/NATIVE_FREQUENCY) with (0xffffffff/NATIVE_FREQUENCY).
Can we go ahead and get this added into the releases? I’ve been using it for months on my Clip+ with dfkt’s build, and it’s rock solid. I’d really like to get this on my 5.5G iPod too.
Does this implement the frequency dependent delay to counter the comb effect?
Eruditass, this implementation should have no comb effect.
I fully agree that this patch is nice addition to the custom rockbox settings, would be nice including it to standard releases.