Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by teru - 2010-11-27
Last edited by teru - 2010-12-15

FS#11777 - enhancement for rockbox_browse()

This patch makes it easier to use rockbox_browse().
- add struct browse_context to be passed to rockbox_browse.
- show proper title when selecting e.g. .wps file or .sbs file from the settings menu.
- use rockbox_browse() to view playlist catalog (see also  FS#11678 ).

*Known issue
browser is messed up if rockbox_browse() is called recursively.
to reproduce:
highlight audio file or playlist in browser → context menu → Playlist Catalog → View Catalog → context menu → Playlist Catalog → Add to Playlist → go back to browser.

future idea maight be to make rockbox_browse() available for generic purpose to select file.
e.g. use it to select file to save configure or playlist, to select .bmp file in rockpaint.

Closed by  teru
2010-12-15 13:03
Reason for closing:  Accepted
Additional comments about closing:  

committed in 28831 & 28836

teru commented on 2010-11-28 12:25

* separate playlist catalog stuff.
* add struct browse_context to struct tree_context so that it doesn't need to be passed through and possibly it can be used in other place (e.g. ft_load).

teru commented on 2010-12-07 12:41

update patch.
* increase number of backups in rockbox_browse so that it can be called recursively bit more.
fixed issue described in the original post.
I set to 3 because currently max nest is 3.
* add callback_show_item member to customize what item will be shown in browser.
* removed BROWSE_ONEDIR as it doesn't seem to work well.

teru commented on 2010-12-14 13:47

I commited browse.patch.

I'll commit browse-plcat.patch tomorrow.

please dont commit browse-plcat.patch, I'm doing the same thing in  FS#11808  and it will already have merge conflicts

teru commented on 2010-12-15 04:07

imo, chaging playlist catalog to use rockbox_browse() should be a separate commit.

teru commented on 2010-12-15 05:56

make playlist_catalog.c similar in the one in  FS#11808 , so there will be less conflicts.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing