- Status Closed
- Percent Complete
- Task Type Patches
- Category User Interface
- Assigned To No-one
- Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Daily build (which?)
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#11777 - enhancement for rockbox_browse()
This patch makes it easier to use rockbox_browse().
- add struct browse_context to be passed to rockbox_browse.
- show proper title when selecting e.g. .wps file or .sbs file from the settings menu.
- use rockbox_browse() to view playlist catalog (see also FS#11678 ).
*Known issue
browser is messed up if rockbox_browse() is called recursively.
to reproduce:
highlight audio file or playlist in browser → context menu → Playlist Catalog → View Catalog → context menu → Playlist Catalog → Add to Playlist → go back to browser.
future idea maight be to make rockbox_browse() available for generic purpose to select file.
e.g. use it to select file to save configure or playlist, to select .bmp file in rockpaint.
Closed by teru
2010-12-15 13:03
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
2010-12-15 13:03
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
committed in 28831 & 28836
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
* separate playlist catalog stuff.
* add struct browse_context to struct tree_context so that it doesn't need to be passed through and possibly it can be used in other place (e.g. ft_load).
browse-playlist_catalog.patch (9.1 KiB)
update patch.
* increase number of backups in rockbox_browse so that it can be called recursively bit more.
fixed issue described in the original post.
I set to 3 because currently max nest is 3.
* add callback_show_item member to customize what item will be shown in browser.
* removed BROWSE_ONEDIR as it doesn't seem to work well.
browse-plcat.patch (9 KiB)
I commited browse.patch.
I'll commit browse-plcat.patch tomorrow.
please dont commit browse-plcat.patch, I'm doing the same thing in
FS#11808and it will already have merge conflictsimo, chaging playlist catalog to use rockbox_browse() should be a separate commit.
make playlist_catalog.c similar in the one in
FS#11808, so there will be less conflicts.