• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category Plugins
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.7.1
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Alexander Meshcheryakov - 2010-12-08
Last edited by MichaelGiacomelli - 2010-12-14

FS#11799 - Less disk activity patch for text viewer plugin

Current text viewer is very greedy for disk accesses. This is very annoying on HDD based players. For example, I’ve expirienced more 5 seconds pauses after “quit” command. This patch changes how saving preferences happens, so in most cases quiting text viewer plugin on HDD based player would be instant.

- tv_save_settings() were called twice upon exiting doubling all disk activity
- if tv_file.dat already had record for current file when preferences were saved tv_file.dat grew one record of garbage

- Much more efficient code for saving preferences. Do not dawdle with temporary tv_file.tmp if this text is opened for the first time or there were no bookmark adding/removals since text were opened.
- Saving settings on exit only if preferences or bookmarks were changed since plugin start or text were scrolled. On devices with HAVE_DISK_STORAGE defined scrolling is ignored.

Closed by  MichaelGiacomelli
2010-12-14 21:34
Reason for closing:  Accepted
Additional comments about closing:  

Committed in r28833.


Available keyboard shortcuts


Task Details

Task Editing