- Status Closed
- Percent Complete
- Task Type Bugs
- Category Battery/Charging
- Assigned To No-one
- Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Release 3.7.1
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
Attached to Project: Rockbox
Opened by MarcinBukat - 2010-12-20
Last edited by MarcinBukat - 2011-01-09
Opened by MarcinBukat - 2010-12-20
Last edited by MarcinBukat - 2011-01-09
FS#11818 - rework ppmviewer to fit our shiny new imageviewer framework
This patch moves ppm decoder to imageviewer.
Closed by MarcinBukat
2011-01-09 13:27
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
2011-01-09 13:27
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
r29012
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
- values added to image_decoder.[ch] need to be surrounded by #if.
- return value of read_ppm isn't checked in load_image in ppm.c
- header of ppm.c contains unrelated comments.
- apps/plugins/CATEGORIES seems to be sorted by plugin name, it would be better to follow the convention.
Thanks teru for review. Please take a look at this fixed version.
- file descriptor is not closed.
- i get a warning when compiling.
/home/teru/rockbox/original/apps/plugins/imageviewer/ppm/ppm.c: In function ‘load_image’:
/home/teru/rockbox/original/apps/plugins/imageviewer/ppm/ppm.c:81: warning: ‘rc’ may be used uninitialize
read_ppm shouldn't be in if (!iv→running_slideshow).
- remove ppmviewer from viewers.config.
it looks fine otherwise.
new version