FS#11828 - Fix core mod metadata parser
Attached to Project:
Rockbox
Opened by Thomas Martitz (kugel.) - Thursday, 23 December 2010, 19:35 GMT
Last edited by Thomas Martitz (kugel.) - Friday, 21 January 2011, 20:09 GMT
Opened by Thomas Martitz (kugel.) - Thursday, 23 December 2010, 19:35 GMT
Last edited by Thomas Martitz (kugel.) - Friday, 21 January 2011, 20:09 GMT
|
DetailsThe mod metadata parser checks if the file in question is a mod file in a very poor manner: not at all. This is a problem when building the database on a PC, because any file that has .mod is accepted, including those text files generated during Linux kernel compilation.
Based on MikiMod, I made this patch to fix it. Please let me know if it rejects any *valid* mod file. It should now accept the same files that the MikMod plugin accepts. |
This task depends upon
Closed by Thomas Martitz (kugel.)
Friday, 21 January 2011, 20:09 GMT
Reason for closing: Accepted
Additional comments about closing: r29105
Friday, 21 January 2011, 20:09 GMT
Reason for closing: Accepted
Additional comments about closing: r29105

Looks fine. Invalid .mod files are correctly ignored during database generation and skipped over if they make it into a playlist. Only thing that sticks out to me is that Mikmod is spelled wrong.

It would be nice to get this committed so that the database is a little more stable.