- Status Closed
- Percent Complete
- Task Type Patches
- Category ID3 / meta data
- Assigned To No-one
- Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Release 3.7.1
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
Attached to Project: Rockbox
Opened by Thomas Martitz - 2010-12-23
Last edited by Thomas Martitz - 2011-01-21
Opened by Thomas Martitz - 2010-12-23
Last edited by Thomas Martitz - 2011-01-21
FS#11828 - Fix core mod metadata parser
The mod metadata parser checks if the file in question is a mod file in a very poor manner: not at all. This is a problem when building the database on a PC, because any file that has .mod is accepted, including those text files generated during Linux kernel compilation.
Based on MikiMod, I made this patch to fix it. Please let me know if it rejects any *valid* mod file. It should now accept the same files that the MikMod plugin accepts.
fix_mod_parser.patch
(2.5 KiB)
Closed by Thomas Martitz
2011-01-21 20:09
Reason for closing: Accepted
Additional comments about closing:
2011-01-21 20:09
Reason for closing: Accepted
Additional comments about closing:
r29105
Looks fine. Invalid .mod files are correctly ignored during database generation and skipped over if they make it into a playlist. Only thing that sticks out to me is that Mikmod is spelled wrong.
It would be nice to get this committed so that the database is a little more stable.