Rockbox

Tasklist

FS#11873 - shutdown_hw waits for disk spindown twice

Attached to Project: Rockbox
Opened by sideral (sideral) - Thursday, 13 January 2011, 09:24 GMT
Last edited by Andree Buschmann (Buschel) - Sunday, 23 January 2011, 12:25 GMT
Task Type Bugs
Category Operating System/Drivers
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

SVN r29045

firmware/powermgmt.c:shutdown_hw() contains the following code snippet twice:

while (storage_disk_is_active())
sleep(HZ/10);

This looks bogus to me.
This task depends upon

Closed by  Andree Buschmann (Buschel)
Sunday, 23 January 2011, 12:25 GMT
Reason for closing:  Accepted
Additional comments about closing:  Changed with r29119.
Comment by Andree Buschmann (Buschel) - Thursday, 13 January 2011, 21:50 GMT
This was introduced with r11507 when submitting  FS#3001 . To me it seems like this was not done intentionally. The latest two patches in  FS#3001  just add the second "while();" whereas all patches before removed the first section and added the second.
So, I am sure we can delete the first call.

Loading...