Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category Operating System/Drivers
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by sideral - 2011-01-13
Last edited by Andree Buschmann - 2011-01-23

FS#11873 - shutdown_hw waits for disk spindown twice

SVN r29045

firmware/powermgmt.c:shutdown_hw() contains the following code snippet twice:

  while (storage_disk_is_active())
      sleep(HZ/10);

This looks bogus to me.

Closed by  Andree Buschmann
2011-01-23 12:25
Reason for closing:  Accepted
Additional comments about closing:  

Changed with r29119.

Andree Buschmann commented on 2011-01-13 21:50

This was introduced with r11507 when submitting  FS#3001 . To me it seems like this was not done intentionally. The latest two patches in  FS#3001  just add the second “while();” whereas all patches before removed the first section and added the
I am sure we can delete the first call.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing