Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category LCD
  • Assigned To No-one
  • Operating System Another
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.7.1
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by PurlingNayuki - 2011-01-18
Last edited by Maurus Cuelenaere - 2011-01-18

FS#11888 - Fix Onda VX777 display error without define #USB_BOOT when compile

When I compile Onda VX777 I must define #USB_BOOT in autoconf.h or Rockbox won't display correctly.
But define this will make it unable to boot OF. So I tried to fix this and success.
Tested on VX777 and VX747. Both of them works well.
This patch may also make VX747P work.

Closed by  Maurus Cuelenaere
2011-01-18 12:10
Reason for closing:  Fixed
Additional comments about closing:  

Should be fixed in r29083.

Thomas Martitz commented on 2011-01-18 08:51

Are there any disadvantages? I wonder why the #ifdef USB_BOOT are there in the first place.

Maurus Cuelenaere commented on 2011-01-18 10:03

USB_BOOT resets and inits the lcd controller, resulting in a white flash when the backlight is on.

Thus I disabled this as the OF bootloader already inits the lcd for us, the ifdef is there for when you boot over usb (then you have to initialize the screen yourself).

Perhaps these changes should be wrapped into an ifndef BOOTLOADER block to make the OF able to boot..

PurlingNayuki commented on 2011-01-18 10:07

1. There're only advantages in my test. All functions works well.
2. I don't know why.
Between every #USB_BOOT and #endif is code to initial SLCD.
But another question is why OndaVX747 don't have to #define this.

But at least, this patch make it work. That's enough, I think.

PurlingNayuki commented on 2011-01-18 10:09

Maurus Cuelenaere (mcuelenaere):
Maybe. I test it again just now, and prove that it do works well on VX747.

Maurus Cuelenaere commented on 2011-01-18 10:12

Yes, but you said it makes the OF boot without working lcd feedback (which I remember seeing when hacking on the OF support).

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing