Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Infrastructure → Build environment
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.7.1
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by MarcinBukat - 2011-01-20
Last edited by MarcinBukat - 2011-06-04

FS#11893 - wpsbuild.pl rewrite

This is complete rewrite of wpsbuild.pl. The differences from old wpsbuild are:
1) Now it uses xml format for WPSLIST file (to make it more consistent) with help of XML::Simple CPAN module.
2) It scans all skin files for graphics needed (not only .wps)
3) Takes lcd dimensions parsing firmware/export/config/modelname.h file directly (instead of bizarre gcc preprocessing and regexp matching)
4) Should be easy to extend (for example to include rec skins if this ever happens)

At first I was thinking about fixing fms support in wpsbuild.pl but it was very hard to follow the code and writing something new from scratch was much easier.

Closed by  MarcinBukat
2011-06-04 21:48
Reason for closing:  Rejected
Additional comments about closing:  

no going to be merged anytime soon

1) wpsbuild2.pl - fix getlcdsizes() to parse correctly LCD defines if there is a comment in the same line
2) buildzip.pl - fix call to wpsbuild2.pl in verbose mode

Changes compared to v2
wpsbuild2.pl
1) some code refactor
2) many small fixes
3) some sanity checks added
4) run with warnings turned on
5) handle all theme related configuration tags

wpsbuild2.pl/buildzip.pl
1) Handle classic_statusbar in wpsbuild2.pl (where this should be!)

WPSLIST.xml
1) reset backdrop to default if needed
2) explicitly state that cabbiev2 uses classic_statusbar.sbs

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing