diff -Naur rockbox.svn/android/src/org/rockbox/Helper/MediaButtonReceiver.java rockbox.fixes/android/src/org/rockbox/Helper/MediaButtonReceiver.java --- rockbox.svn/android/src/org/rockbox/Helper/MediaButtonReceiver.java 2011-01-31 21:16:03.000000000 -0600 +++ rockbox.fixes/android/src/org/rockbox/Helper/MediaButtonReceiver.java 2011-02-02 16:53:49.000000000 -0600 @@ -80,11 +80,7 @@ if (Intent.ACTION_MEDIA_BUTTON.equals(intent.getAction())) { KeyEvent key = (KeyEvent)intent.getParcelableExtra(Intent.EXTRA_KEY_EVENT); - if (key.getAction() == KeyEvent.ACTION_UP) - { /* pass the pressed key to Rockbox */ - if (RockboxService.get_instance().get_fb().dispatchKeyEvent(key)) - abortBroadcast(); - } + RockboxService.get_instance().get_fb().dispatchKeyEvent(key); } } } diff -Naur rockbox.svn/android/src/org/rockbox/RockboxService.java rockbox.fixes/android/src/org/rockbox/RockboxService.java --- rockbox.svn/android/src/org/rockbox/RockboxService.java 2011-01-31 21:16:04.000000000 -0600 +++ rockbox.fixes/android/src/org/rockbox/RockboxService.java 2011-02-02 16:53:49.000000000 -0600 @@ -122,22 +122,22 @@ if (intent.getAction().equals("org.rockbox.PlayPause")) { if (fb != null) - fb.onKeyUp(KeyEvent.KEYCODE_MEDIA_PLAY_PAUSE, null); + fb.onKeyDown(KeyEvent.KEYCODE_MEDIA_PLAY_PAUSE, null); } else if (intent.getAction().equals("org.rockbox.Prev")) { if (fb != null) - fb.onKeyUp(KeyEvent.KEYCODE_MEDIA_PREVIOUS, null); + fb.onKeyDown(KeyEvent.KEYCODE_MEDIA_PREVIOUS, null); } else if (intent.getAction().equals("org.rockbox.Next")) { if (fb != null) - fb.onKeyUp(KeyEvent.KEYCODE_MEDIA_NEXT, null); + fb.onKeyDown(KeyEvent.KEYCODE_MEDIA_NEXT, null); } else if (intent.getAction().equals("org.rockbox.Stop")) { if (fb != null) - fb.onKeyUp(KeyEvent.KEYCODE_MEDIA_STOP, null); + fb.onKeyDown(KeyEvent.KEYCODE_MEDIA_STOP, null); } } diff -Naur rockbox.svn/apps/keymaps/keymap-android.c rockbox.fixes/apps/keymaps/keymap-android.c --- rockbox.svn/apps/keymaps/keymap-android.c 2011-01-31 21:17:32.000000000 -0600 +++ rockbox.fixes/apps/keymaps/keymap-android.c 2011-02-02 18:29:06.000000000 -0600 @@ -41,11 +41,11 @@ { ACTION_STD_PREV, BUTTON_DPAD_UP|BUTTON_REL, BUTTON_NONE }, { ACTION_STD_NEXT, BUTTON_DPAD_DOWN|BUTTON_REL, BUTTON_NONE }, - { ACTION_STD_OK, BUTTON_DPAD_CENTER, BUTTON_NONE }, + { ACTION_STD_OK, BUTTON_DPAD_CENTER|BUTTON_REL, BUTTON_NONE }, { ACTION_STD_OK, BUTTON_DPAD_RIGHT|BUTTON_REL, BUTTON_NONE }, - { ACTION_STD_CANCEL, BUTTON_BACK, BUTTON_NONE }, + { ACTION_STD_CANCEL, BUTTON_BACK|BUTTON_REL, BUTTON_NONE }, { ACTION_STD_CANCEL, BUTTON_BACK|BUTTON_REPEAT, BUTTON_BACK }, - { ACTION_STD_CANCEL, BUTTON_DPAD_LEFT|BUTTON_REL, BUTTON_NONE }, + { ACTION_STD_CANCEL, BUTTON_DPAD_LEFT|BUTTON_REPEAT, BUTTON_NONE }, { ACTION_STD_MENU, BUTTON_MENU|BUTTON_REL, BUTTON_MENU }, { ACTION_STD_CONTEXT, BUTTON_MENU|BUTTON_REPEAT, BUTTON_MENU }, @@ -54,7 +54,7 @@ }; /* button_context_standard */ static const struct button_mapping button_context_wps[] = { - { ACTION_WPS_BROWSE, BUTTON_BACK, BUTTON_NONE }, + { ACTION_WPS_BROWSE, BUTTON_BACK|BUTTON_REL, BUTTON_NONE }, { ACTION_WPS_MENU, BUTTON_MENU|BUTTON_REL, BUTTON_MENU }, { ACTION_WPS_CONTEXT, BUTTON_MENU|BUTTON_REPEAT, BUTTON_MENU }, @@ -80,8 +80,8 @@ static const struct button_mapping button_context_settings[] = { { ACTION_SETTINGS_INC, BUTTON_DPAD_RIGHT|BUTTON_REL, BUTTON_NONE }, { ACTION_SETTINGS_DEC, BUTTON_DPAD_LEFT|BUTTON_REL, BUTTON_NONE }, - { ACTION_STD_OK, BUTTON_DPAD_CENTER, BUTTON_NONE }, - { ACTION_STD_CANCEL, BUTTON_BACK, BUTTON_NONE }, + { ACTION_STD_OK, BUTTON_DPAD_CENTER|BUTTON_REL, BUTTON_NONE }, + { ACTION_STD_CANCEL, BUTTON_BACK|BUTTON_REL, BUTTON_NONE }, LAST_ITEM_IN_LIST__NEXTLIST(CONTEXT_STD) }; /* button_context_settings */ @@ -92,7 +92,7 @@ }; /* button_context_settingsgraphical */ static const struct button_mapping button_context_yesno[] = { - { ACTION_YESNO_ACCEPT, BUTTON_DPAD_CENTER, BUTTON_NONE }, + { ACTION_YESNO_ACCEPT, BUTTON_DPAD_CENTER|BUTTON_REL, BUTTON_NONE }, LAST_ITEM_IN_LIST__NEXTLIST(CONTEXT_STD) }; /* button_context_settings_yesno */ diff -Naur rockbox.svn/firmware/target/hosted/android/app/button-application.c rockbox.fixes/firmware/target/hosted/android/app/button-application.c --- rockbox.svn/firmware/target/hosted/android/app/button-application.c 2011-01-31 21:17:58.000000000 -0600 +++ rockbox.fixes/firmware/target/hosted/android/app/button-application.c 2011-02-02 16:53:49.000000000 -0600 @@ -39,15 +39,14 @@ return BUTTON_MENU; case KEYCODE_DPAD_CENTER: return BUTTON_DPAD_CENTER; - default: - return BUTTON_NONE; - } -} - -unsigned multimedia_to_button(int keyboard_key) -{ - switch (keyboard_key) - { + case KEYCODE_DPAD_UP: + return BUTTON_DPAD_UP; + case KEYCODE_DPAD_DOWN: + return BUTTON_DPAD_DOWN; + case KEYCODE_DPAD_LEFT: + return BUTTON_DPAD_LEFT; + case KEYCODE_DPAD_RIGHT: + return BUTTON_DPAD_RIGHT; case KEYCODE_MEDIA_PLAY_PAUSE: return BUTTON_MULTIMEDIA_PLAYPAUSE; case KEYCODE_MEDIA_STOP: @@ -61,28 +60,7 @@ case KEYCODE_MEDIA_FAST_FORWARD: return BUTTON_MULTIMEDIA_FFWD; default: - return 0; - } -} - -unsigned dpad_to_button(int keyboard_key) -{ - switch (keyboard_key) - { - /* These buttons only post a single release event. - * doing otherwise will cause action.c to lock up waiting for - * a release (because android sends press/unpress to us too quickly - */ - case KEYCODE_DPAD_UP: - return BUTTON_DPAD_UP|BUTTON_REL; - case KEYCODE_DPAD_DOWN: - return BUTTON_DPAD_DOWN|BUTTON_REL; - case KEYCODE_DPAD_LEFT: - return BUTTON_DPAD_LEFT|BUTTON_REL; - case KEYCODE_DPAD_RIGHT: - return BUTTON_DPAD_RIGHT|BUTTON_REL; - default: return BUTTON_NONE; } } - + diff -Naur rockbox.svn/firmware/target/hosted/android/button-android.c rockbox.fixes/firmware/target/hosted/android/button-android.c --- rockbox.svn/firmware/target/hosted/android/button-android.c 2011-01-31 21:17:58.000000000 -0600 +++ rockbox.fixes/firmware/target/hosted/android/button-android.c 2011-02-02 16:57:47.000000000 -0600 @@ -69,37 +69,31 @@ unsigned button = 0; - if (!state) + if (state) { - button = multimedia_to_button((int)keycode); - if (!button) - button = dpad_to_button((int)keycode); - if (button) - queue_post(&button_queue, button, 0); - } - - if (!button) - { button = key_to_button(keycode); - } - - if (button == BUTTON_NONE) - { + if (button == BUTTON_NONE) + { + last_btns = 0; + return false; + } + if (button) + { + queue_post(&button_queue, button, 0); last_btns = button; - return false; + return true; + } } - if (state) - { - last_btns |= button; - } - else + if (!state) { - last_btns &= (~button); - return false; + last_btns = 0; + queue_post(&button_queue, BUTTON_REL, 0); + return true; } - - return true; + + return false; + } void button_init_device(void)