Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Utils
  • Assigned To
    bluebrother
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by bluebrother - 2011-01-29
Last edited by bluebrother - 2012-09-23

FS#11913 - Move TTS correction expressions out of voice.pl into a separate file

The attached patch moves the TTS correction expressions into a separate file tools/voice-corrections.txt and adjusts voice.pl to use that. This will allow it to reuse the correction expressions from other programs as well with Rockbox Utility being an interesting candidate (I have a first version of Rockbox Utility using voice-corrections.txt working, but currently there is too much hard coded to create a useful patch from that).

Since I’m not too familiar with Perl I would appreciate comments if the changes made to voice.pl are done in a sensible way.

Closed by  bluebrother
2012-09-23 19:37
Reason for closing:  Accepted
Additional comments about closing:  

Has been accepted over a year ago – r29500.

This patch goes on top of the first one and uses voice-corrections.txt in Rockbox Utility. There are currently a couple of limitations (vendor will get ignored, only implemented for voicefile creation) but unless there are concerns about the approach of the initial patch I see this as potential first use implementation.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing