Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category ID3 / meta data
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.7.1
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Andree Buschmann - 2011-02-03
Last edited by Andree Buschmann - 2011-02-20

FS#11920 - possible savings when reading metadata

Rockbox’ ID3 parser does not trim strings fields with in-lying null-termination or multiple zeroes at the string field end. For ape, aac and ogg this is already done.

This patch adds trimming to the ID3 parser in a very simple way. The next item is allowed to be written beyond the next following null in the array. Savings are few, but could be interesting for our reduced metadata size on low memory targets.

Closed by  Andree Buschmann
2011-02-20 16:21
Reason for closing:  Accepted
Additional comments about closing:  

Submitted with r29349.

Andree Buschmann commented on 2011-02-10 21:21

The v02 version adds savings for ape- and mp4-tags as well.

Example: In case of multiple genre tags the current svn implementation will read each genre item seperately, write it to id3v2buf and set id3→genre to the last read genre. This way there might be several gernes written to id3v2buf, but only the last one will be valid. In effect we're wasting bytes.

Possible solution in this patch is to only add a new metadata item to id3v2buf, if the dedicated pointer within the id3-struct is still empty.

Andree Buschmann commented on 2011-02-13 16:45

This v03 version only minor impacts the binary size.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing