- Status Closed
- Percent Complete
- Task Type Patches
- Category Infrastructure → Build environment
- Assigned To No-one
- Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Release 3.7.1
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#11924 - Use separate targets for RaaA devices
This patch changes tools/configure to list the available RaaA targets in the main list of targets, instead of using a generic “Application” option with a follow-up question.
This also uses different target_id values for the different targets. The implication of this (I think) is that separate voice/lang files are required for each RaaA. IMO this is correct as they can potentially differ in the available features.
I’ll commit this after it is confirmed I haven’t broken anything - I don’t have the Android or Maemo SDKs installed yet.
configure-app-targets-v1.diff
(12.7 KiB)
Closed by linuxstb
2011-02-11 19:52
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
2011-02-11 19:52
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
v4 of patch committed as r29286
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
Hello Dave,
took a quick look at it and it seems fine. I can give it a test run in the evening.
The “debian/rules” CONFIGURE_OPTIONS will break by this change. Should be easy to fix:
Add the pkgconfig call in there and determine the maemo version, too.
Cheers,
Thomas
Attached is an updated patch which fixes some issues found, including “make reconf” not working and maemo4cc being incomplete.
More fixes. Revert to the original maemocc function, passing the required maemo version as a parameter.
This patch includes (untested) changes to debian/rules to choose the correct target based on the version of the Maemo SDK activated
Hey Dave,
thanks for the updated patch, I’ll give it a test run in the evening.
Thomas
Patch v4 works fine, it builds the binary package out of the box.
I’d say commit it :)