Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.7.1
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Jonathan Gordon - 2011-02-11
Last edited by Jonathan Gordon - 2011-06-01

FS#11925 - Add a proper "current screen" system

This patch makes adds a very simple system so themers can know exactly which screen it is in (to mangle the sbs as required).

This first patch is untested and only adds the browsers and quickscreen. others can be added if this is wanted/works.

All that is needed to do to add a new screen is add the screen to the enum at the bottom of misc.h, then when entering the screen call push_current_screen() and when exiting call pop_current_screen().

   current_screen.patch (4.6 KiB)
Closed by  Jonathan Gordon
2011-06-01 14:42
Reason for closing:  Accepted
Additional comments about closing:  

r29944

Michael Sevakis commented on 2011-02-11 02:45

Add tester .sbs and this one compiles :)

   test.sbs (0.1 KiB)
   current-screen-compiles.patch (5.2 KiB)
Jonathan Gordon commented on 2011-05-31 13:52

update to add a bunch more screens… want to commit soon… need a better enum prefix than SCREEN_

   changes.patch (7.7 KiB)
Jonathan Gordon commented on 2011-06-01 04:53

fix the ordering so %cs tag doesnt change the order

   changes.patch (7.7 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing