Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category ID3 / meta data
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.7.1
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Buschel - 2011-02-22
Last edited by Buschel - 2011-02-22

FS#11960 - Limit max. metadata item size

With r29174 I have submitted a limit for the size of each metadata item. This is helpful to avoid that few items (like excessive comments) eat up the fixed size metadata buffer. This is especially important on LOW_MEM targets.
r29174 implemented this limitation for id3 tags only. This patch adds the same limitation to mp4 and other tags as well. Please verify this patch against your files.

Of special interest is handling of replaygain data in mp4 files. Can anyone attach or link one or two mp4 sample files with replaygain data?

   tag_limit_v01.patch (1.5 KiB)
Closed by  Buschel
2011-02-22 07:54
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Submitted with r29377.

saratoga commented on 2011-02-22 04:50

http://duke.edu/~mgg6/rockbox/nero_096.m4a

Applied replaygain using foobar2000.

Buschel commented on 2011-02-22 07:54

Thanks for the file. My last commit to apps/metadata/mp4.c introduced an error in replaygain parsing. I corrected this bug with r29376. After fixing this issue I also submitted thi patch with r29377.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing