Rockbox

Tasklist

FS#11960 - Limit max. metadata item size

Attached to Project: Rockbox
Opened by Andree Buschmann (Buschel) - Tuesday, 22 February 2011, 02:10 GMT
Last edited by Andree Buschmann (Buschel) - Tuesday, 22 February 2011, 07:54 GMT
Task Type Patches
Category ID3 / meta data
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Release 3.7.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

With r29174 I have submitted a limit for the size of each metadata item. This is helpful to avoid that few items (like excessive comments) eat up the fixed size metadata buffer. This is especially important on LOW_MEM targets.
r29174 implemented this limitation for id3 tags only. This patch adds the same limitation to mp4 and other tags as well. Please verify this patch against your files.

Of special interest is handling of replaygain data in mp4 files. Can anyone attach or link one or two mp4 sample files with replaygain data?
This task depends upon

Closed by  Andree Buschmann (Buschel)
Tuesday, 22 February 2011, 07:54 GMT
Reason for closing:  Accepted
Additional comments about closing:  Submitted with r29377.
Comment by MichaelGiacomelli (saratoga) - Tuesday, 22 February 2011, 04:50 GMT
http://duke.edu/~mgg6/rockbox/nero_096.m4a

Applied replaygain using foobar2000.
Comment by Andree Buschmann (Buschel) - Tuesday, 22 February 2011, 07:54 GMT
Thanks for the file. My last commit to apps/metadata/mp4.c introduced an error in replaygain parsing. I corrected this bug with r29376. After fixing this issue I also submitted thi patch with r29377.

Loading...