Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category User Interface
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.8
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Buschel - 2011-03-22
Last edited by Buschel - 2011-03-24

FS#12024 - List scroll acceleration on non-scrollwheel targets

A forum post (http://forums.rockbox.org/index.php/topic,27409.0.html) made me check the code and the manual for the settings “List Acceleration Start Delay” and “List Acceleration Speed”.

1) There is no manual entry for those settings.
2) The unit for “List Acceleration Start Delay” was UNIT_MS, correct is UNIT_SEC.
3) The implementation used HZ/2 instead of HZ for the delays.
4) The implementation did not double the scroll speed each step.
5) The recognition of a repeated key in action.c uses a too short window (HZ/10). The recognition works more reliable in my tests with HZ/4.

Closed by  Buschel
2011-03-24 18:53
Reason for closing:  Fixed
Additional comments about closing:  

Kept the linear acceleration but fixed manual and the acceleration in general.

Why double the scroll speed? That's nonlinear acceleration, that doesn't sound nice.

Depends on how it feels if used. I cannot judge this as I do only have scrollwheel targets and could only test on simulator. Regarding nonlinearity: On scrollwheel targets like the iPod the acceleration is list speed = v^3 (v=rotation speed of wheel) – for this usecase it feels just right.

Do you have the possibility to test this patch on a target?

New version of the patch for the manual.

Submitted apps/settings_list.c and manual/configure_rockbox/display_options.tex as a first step (r29634). Using the correct time base (HZ instead of HZ/2) was 2nd step (r29635).

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing