FS#12056 - Xobox: Xonix starts moving on its own (without any keypress) at beginning of a level

Attached to Project: Rockbox
Opened by Ophir Lojkine (lovasoa) - Saturday, 09 April 2011, 14:44 GMT
Last edited by MichaelGiacomelli (saratoga) - Sunday, 24 April 2011, 23:52 GMT
Task Type Patches
Category Games
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Release 3.8.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


Steps to reproduce the bug:
1. Start playing xobox
2. When you are about to finish the first level, keep the down key pressed to cut a part of the infected area.
3. Keep the key pressed even when it tells you «first level finished».
4. On the second level, your key press will still be in the buffer, and xonix will start moving even if you are not pressing a key anymore.

My little patch just adds a call to rb->button_clear_queue(); at the beginning of every new level.
This task depends upon

Closed by  MichaelGiacomelli (saratoga)
Sunday, 24 April 2011, 23:52 GMT
Reason for closing:  Accepted
Additional comments about closing:  Accepted in r29781.
Comment by Ophir Lojkine (lovasoa) - Saturday, 09 April 2011, 15:05 GMT
The fix is trivial, and all credits go to the one who discovered the bug.
So I want to thank my little brother, Noah, a 7 year old xobox addict.
Comment by Hayden Pearce (St.) - Sunday, 10 April 2011, 08:56 GMT
Thankyou Lovasoa (and Noah) for finding this,

Months ago my girlfriend noticed this, told me about it, and I forgot about it almost immediately ;)

I have tested that this occurs on my available targets, Nano 1/2G, and 4G/Color.
Also confirmed this your little patch does indeed fix the issue.

Comment by Thomas Martitz (kugel.) - Tuesday, 12 April 2011, 16:20 GMT
But it has tabs!
Comment by Ophir Lojkine (lovasoa) - Tuesday, 19 April 2011, 21:12 GMT
Can someone commit this patch to the svn?
That would make my little brother very happy...