• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category Drivers
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Ophir Lojkine - 2011-04-24
Last edited by Bertrik Sikken - 2011-04-27

FS#12079 - Support for new commands in iap.c

This is my first consequent patch to rockbox, so I may have done a lot of mistakes, please be indulgent.

This patch implements several new commands in iap.c to support some stuff related to playlists. Basically, this allows me to access quickly my playlists from my iPod dock.

Closed by  Bertrik Sikken
2011-04-27 06:25
Reason for closing:  Accepted
Additional comments about closing:  

Committed as SVN r29788, thanks!

Ophir Lojkine commented on 2011-04-24 23:36

I didn’t join the patch…

Bertrik Sikken commented on 2011-04-25 11:43

I cleaned up the patch a bit:
* removed tabs, replaced them by spaces (please read docs/CONTRIBUTING)
* renamed current_item to cur_dbrecord (I think this is more descriptive)
* commented commands according to specification
* fixed calculation of item_offset (bytes not shifted properly)
* fixed conflict with lingo0/cmd6

I’d like to have this reviewed by another rockbox developer with regards to the playlist logic.

Ophir Lojkine commented on 2011-04-25 13:29

Wow, you have been very fast. You motivated me to uget_playlist_namepdate my patch again.
- I changed get_playlist_name() to avoid buffer overflow,
- added a check to verify that the files returned are actually playlists
- and prevented the remote device to print files extensions

Again, thanks for your interest…

Ophir Lojkine commented on 2011-04-25 13:30

Hmmm; Again! I didn’t join the patch! It should be possible to edit previous posts!


Available keyboard shortcuts


Task Details

Task Editing