- Status Closed
- Percent Complete
- Task Type Bugs
- Category Codecs
- Assigned To No-one
- Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Release 3.8.1
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#12081 - compile warnings (out-of-bounds) in libfaad
Magnus Holmgren reported compiler warnings with GCC 4.6.0 in libfaad/decoder.c since r29778. The multiple warning starts at line 605: “warning: array subscript is above array bounds [-Warray-bounds]”
Reason for this is that I reduced MAX_CHANNELS to 2 (= stereo). The reported section in function create_channel_config() accesses channel_position[] at too large indices.
I reviewed the code and did some changes:
1) comment create_channel_config() as this is only used to set variables which are not used later
2) let NeAACDecInit() and NeAACDecInit2() return an error if more than MAX_CHANNELS channels are recognized
Closed by Buschel
2011-04-26 21:31
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
2011-04-26 21:31
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
Validated by Magnus Holmgren, submitted
with r29784.
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
You don't seem to be a fan of #ifndef ROCKBOX?
No. And as our libfaad-implementation has already been altered quite a lot I see no reason in keeping it syncable until we do not switch to another implementation (e.g. ffmpeg or google).