Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.8.1
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by lovasoa - 2011-05-07
Last edited by fg - 2011-05-15

FS#12104 - Prefill the playlist name when creating a new playlist from the file browser (or from elsewhere)

As it’s not easy to enter text on a small DAAP, adding a new playlist from the file browser took a long time. We had to enter the full name of the playlist from the keyboard.
With this patch, we can still enter text, but the text field is prefilled with the name of the directory, or file, from which the playlist is created.

   playlist_prefilled_name.patch (0.6 KiB)
Closed by  fg
2011-05-15 10:38
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Committed as r29882

lovasoa commented on 2011-05-08 07:03

I updated the patch. It makes sense to prefill the text field only when the playlist is generated from a folder.
If it’s generated from a file, the user will want to add other files, and rarely to name the playlist according to the first file in it.
If it’s already a playlist, as it’s odd to copy a playlist into another playlist, the user will want to add other files or playlists to the current one, and will not want to give to the new playlist the same name as the original one.

   playlist_prefilled_name.patch (0.7 KiB)
nls commented on 2011-05-09 21:45

I think this looks good but i’d prefer if you’d leave the +1 to when name is accessed, since name!=NULL+1 looks really weird to me

lovasoa commented on 2011-05-09 22:07

You are right. It was silly!

   playlist_prefilled_name.patch (0.7 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing