Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Drivers
  • Assigned To No-one
  • Operating System Sansa AMSv2
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by keyb_gr - 2011-05-11
Last edited by saratoga - 2011-07-24

FS#12111 - AS3543: Turn off output mixer AGC as done in AMSv1

While AMSv1 targets are set up to disable output mixer AGC, this is not done on AS3543 equipped ones for some reason. The provided patch corrects that.

Available headroom does not seem to be changed in digital audio playback.

Two versions are provided, one for a standard Rockbox and another that includes the “audiophile patch”  FS#11304  (some overlap in modified registers there).

   as3543-agc-off-std.diff (1.2 KiB)
   as3543-agc-off-withfs11304.di... (1.4 KiB)
Closed by  saratoga
2011-07-24 21:57
Reason for closing:  Accepted
Additional comments about closing:  

Accepted first patch as r30208. Further discussion for  FS#11304  can continue in its task.

dfkt commented on 2011-05-19 15:39

I did some RMAA tests on that patch, against a clean default build - results can be seen here: http://anythingbutipod.com/forum/showpost.php?p=554724&postcount=1337

Aoyumi commented on 2011-06-04 21:07

I tested first patch.
It prevents a change of irregular volume in the music that is very high in mean volume. The patch seems to be surely effective.

sideral commented on 2011-07-21 20:58

I’ve been running with this patch (in my case the second patch) for a few weeks without issues. I think it can be committed safely.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing