Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Codecs
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.8.1
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Andree Buschmann - 2011-05-14
Last edited by Andree Buschmann - 2011-05-22

FS#12115 - Use more IRAM for cook, use MEM_ALIGN_ATTR

This patch moves a few arrays to IRAM and makes use of MEM_ALIGN_ATTR. Performance is slightly increasing on iPod nano 2G (+1-2%) and stable on iPod Video. I would like to see a test on Coldfire targets as well.

Closed by  Andree Buschmann
2011-05-22 19:18
Reason for closing:  Accepted
Additional comments about closing:  

Submitted with r29913.

Andree Buschmann commented on 2011-05-14 21:49

You may use the attached test file.

Michael Sevakis commented on 2011-05-14 22:12

r29684 / w/cook_v01.patch

H100 (MCF5249):
cook_stereo_64.ra:27.76MHz:39.33s / 27.70MHz:39.24s (+0.22%)

X5 (MCF5250):
cook_stereo_64.ra:27.91MHz:39.54s / 27.87MHz:39.48s (+0.10%)

Michael Sevakis commented on 2011-05-15 21:51

I was slightly lurking in IRC. What's new here to test?

Andree Buschmann commented on 2011-05-16 05:36

My fault, I was asking you to test this even though you already did… But you might check  FS#12117 .

Andree Buschmann commented on 2011-05-16 22:07

Several new changes. Speedup on nano 2G is +3% now.

Michael Sevakis commented on 2011-05-16 22:20

X5 (MCF5250):
r29887 / w/cook_v02.patch
cook_stereo_64.ra: 27.95MHz:39.60s / 27.54MHz:39.01s (+1.49%)

Andree Buschmann commented on 2011-05-19 21:39

Moved several VLC data arrays to IRAM. Performance needs to be measured again.

Michael Sevakis commented on 2011-05-19 22:08

(Using same results above for comparison)
X5 (MCF5250):
r29887 / r29899 w/cook_v04.patch
cook_stereo_64.ra: 27.95MHz:39.60s / 27.23MHz:38.58s (+2.64%)

Edit: Fix patch name

Andree Buschmann commented on 2011-05-20 06:14

svn / patch (in MHz) for cook_stereo_64.ra

iPod Video: 28.08 / 27.55 ⇒ +1.9%
iPod nano 2G: 45.85 / 44.31 ⇒ +3.5%

Andree Buschmann commented on 2011-05-20 21:54

The VLC-tables were all using the same size (VLCBUFSIZE). This patch reduces the overall size of the VLC tables by more than a factor of 2. As a result more VLC tables can be moved to IRAM for PP5022, PP5024, MCF5250 and S5L870x. Speed increases a bit further:

iPod Video: 28.08 / 27.36 ⇒ +2.6%
iPod nano 2G: 45.85 / 44.27 ⇒ +3.5%

Jens Arnold commented on 2011-05-22 11:48

svn / patch v06 (in MHz) for cook_stereo_64.ra

iPod 2nd Gen (PP5002): 36.67 / 36.61 =⇒ +0.16 %
Iriver H10 6GB (PP5020): 31.63 / 32.19 =⇒ -1.7 %

Andree Buschmann commented on 2011-05-22 17:26

Same speed as svn for PP5002 and PP5020.

PP5022: 28.08 / 27.32 ⇒ +2.8%
S5L870x: 45.85 / 44.91 ⇒ +2.1%
MCF5250: 27.67 / 26.82 ⇒ +3.1%

Andree Buschmann commented on 2011-05-22 19:00

Move several functions to IRAM for S5L, speed on S5L870x: 45.85 / 44.00 ⇒ +4.4%

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing