FS#12126 - Crossfade On Manual Track Change In Shuffle Only Mode of Crossfade

Attached to Project: Rockbox
Opened by Akbar Hashim (akbarhash) - Sunday, 22 May 2011, 20:15 GMT
Task Type Bugs
Category Music playback
Status Unconfirmed
Assigned To No-one
Operating System Sansa AMSv2
Severity Low
Priority Normal
Reported Version Release 3.8.1
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No


would like to report a bug in crossfade.
when i am shuffling through songs and set crossfade to shuffle only it still fades when i do a manual track change this does not happen when i set shuffle off.
this should not occur as there is an option for shuffle and manual track change only, so the two options have the same functionality when i am shuffling it should be able to differentiate between them.
It should be able to register that i have pressed next so the next song should not fade even though it is on shuffle.
This task depends upon

Comment by Akbar Hashim (akbarhash) - Sunday, 22 May 2011, 20:32 GMT
Sorry but i can't edit this flyspray so here is where i am correcting the above statement.
When I have the Shuffle mode On & Crossfade is set on Shuffle Mode:

Even manual track changes are registered as Shuffle and the player crossfades the next track on manual track change.

When I have the Shuffle mode On & Crossfade is set on Shuffle Mode or Manual Track Skip

The functionality remains the same.

Maybe there should be an option like:
"shuffle, but not manual track changes while shuffling"
Comment by Jeffrey Goode (Blue_Dude) - Tuesday, 31 May 2011, 05:24 GMT
This is not actually a bug. The crossfade behavior you describe is exactly what is supposed to happen. You can certainly request a change in behavior, or for another crossfade option to be added, to get what you want.

One suggestion is for the shuffle mode be changed to only crossfade for automatic track changes. This would require only a small patch to the crossfade code and manual, with no change to menus. You would lose crossfade for manual changes in shuffle mode (which is what you want), but you can get that functionality back with Shuffle or Manual and it will work outside of shuffle mode as well. You should bring up the topic on IRC or send an email to the dev list to see if there are any objections to changing the crossfade functionality in this manner. I could make that change in just a few minutes.