Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Database
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.8.1
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by nls - 2011-05-29
Last edited by nls - 2011-05-31

FS#12136 - Save some binsize in tagtree.c

This patch replaces a macro for testing string equality used many times with loops over arrays of pointers. Saves about 700bytes on a cf build.

   tagtree_size.diff (6.2 KiB)
Closed by  nls
2011-05-31 19:45
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

comitted

Buschel commented on 2011-05-30 05:49

Saves ~1200 Byte on a nano 2G build.

pamaury commented on 2011-05-30 07:28

Looks like a reasonable thing to do.

sideral commented on 2011-05-30 09:58

My initial testing looks good. I'll report back after some more testing in a couple of days.

Maybe you could save even more binsize by factoring out the loops as well (into a small utility function)?

nls commented on 2011-05-31 14:23

Thanks for testing, i made a quick test with the matching loop broken out into a separate function but it made no significant change to size (12 bytes bigger on cf, same size on arm (gigabeast))

sideral commented on 2011-05-31 18:17

My testing over the last few days has not revealed any issues. I think you can commit this patch. Cheers!

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing