Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Deprecated: Function create_function() is deprecated in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 104 Deprecated: The each() function is deprecated. This message will be suppressed on further calls in /sites/rockbox.org/flyspray/adodb/adodb.inc.php on line 845 Deprecated: Function create_function() is deprecated in /sites/rockbox.org/flyspray/includes/class.user.php on line 111 FS#12141 : Remove/comment unused codec code

Rockbox

Tasklist

FS#12141 - Remove/comment unused codec code

Attached to Project: Rockbox
Opened by Sean Bartell (wtachi) - Wednesday, 01 June 2011, 05:20 GMT
Last edited by Nils Wallménius (nls) - Thursday, 02 June 2011, 17:15 GMT
Task Type Patches
Category Codecs
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Some of these were found with http://www.samba.org/junkcode/#findstatic. Changes of note:
* The old MDCT has been removed.
* Makefile.test files that create test programs for libatrac, libcook, and libffmpegFLAC have been removed, as they don't work. My project will have a replacement that works with all codecs.
* I've tried not to remove anything useful. CLIP_TO_15 was removed from libtremor because there's another copy (also commented) in codeclib.
   0002-Remove-comment-unused-co... (45.7 KiB)
This task depends upon

Closed by  Nils Wallménius (nls)
Thursday, 02 June 2011, 17:15 GMT
Reason for closing:  Accepted
Additional comments about closing:  Committed, thanks!
Comment by Nils Wallménius (nls) - Wednesday, 01 June 2011, 10:34 GMT
Will the c files for the test programs be used by your replacement or should those be removed too?
Comment by Sean Bartell (wtachi) - Wednesday, 01 June 2011, 15:46 GMT
Whoops, I forgot those.
   0002-Remove-comment-unused-co... (67.7 KiB)
Comment by Sean Bartell (wtachi) - Wednesday, 01 June 2011, 21:24 GMT
It turns out libfaad error messages are needed even when LOGF isn't enabled. The patch has been fixed accordingly.
   0002-Remove-comment-unused-co... (67.1 KiB)

Loading...