Warning: Undefined array key "useheading" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 1099 Warning: Undefined array key "target" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557 Warning: Trying to access array offset on value of type null in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557 FS#12141 : Remove/comment unused codec code

Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Codecs
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by wtachi - 2011-06-01
Last edited by nls - 2011-06-02

FS#12141 - Remove/comment unused codec code

Some of these were found with http://www.samba.org/junkcode/#findstatic. Changes of note:

  • The old MDCT has been removed.
  • Makefile.test files that create test programs for libatrac, libcook, and libffmpegFLAC have been removed, as they don’t work. My project will have a replacement that works with all codecs.
  • I’ve tried not to remove anything useful. CLIP_TO_15 was removed from libtremor because there’s another copy (also commented) in codeclib.
   0002-Remove-comment-unused-co... (45.7 KiB)
Closed by  nls
2011-06-02 17:15
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Committed, thanks!

nls commented on 2011-06-01 10:34

Will the c files for the test programs be used by your replacement or should those be removed too?

wtachi commented on 2011-06-01 15:46

Whoops, I forgot those.

   0002-Remove-comment-unused-co... (67.7 KiB)
wtachi commented on 2011-06-01 21:24

It turns out libfaad error messages are needed even when LOGF isn’t enabled. The patch has been fixed accordingly.

   0002-Remove-comment-unused-co... (67.1 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing