- Status Closed
- Percent Complete
- Task Type Patches
- Category Codecs
- Assigned To No-one
- Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Daily build (which?)
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
Attached to Project: Rockbox
Opened by Sean Bartell - 2011-06-01
Last edited by Nils Wallménius - 2011-06-02
Opened by Sean Bartell - 2011-06-01
Last edited by Nils Wallménius - 2011-06-02
FS#12141 - Remove/comment unused codec code
Some of these were found with http://www.samba.org/junkcode/#findstatic. Changes of note:
- The old MDCT has been removed.
- Makefile.test files that create test programs for libatrac, libcook, and libffmpegFLAC have been removed, as they don’t work. My project will have a replacement that works with all codecs.
- I’ve tried not to remove anything useful. CLIP_TO_15 was removed from libtremor because there’s another copy (also commented) in codeclib.
0002-Remove-comment-unused-co...
(45.7 KiB)
Closed by Nils Wallménius
2011-06-02 17:15
Reason for closing: Accepted
Additional comments about closing:
2011-06-02 17:15
Reason for closing: Accepted
Additional comments about closing:
Committed, thanks!
Will the c files for the test programs be used by your replacement or should those be removed too?
Whoops, I forgot those.
It turns out libfaad error messages are needed even when LOGF isn’t enabled. The patch has been fixed accordingly.