Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Deprecated: Function create_function() is deprecated in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 104 Deprecated: The each() function is deprecated. This message will be suppressed on further calls in /sites/rockbox.org/flyspray/adodb/adodb.inc.php on line 845 Deprecated: Function create_function() is deprecated in /sites/rockbox.org/flyspray/includes/class.user.php on line 111 FS#12149 : Read Lyricist/Text writer from mp3 id3 tag for display in wps

Rockbox

Tasklist

FS#12149 - Read Lyricist/Text writer from mp3 id3 tag for display in wps

Attached to Project: Rockbox
Opened by Kaname Madoka (Lyrical Madoka) - Sunday, 05 June 2011, 08:45 GMT
Task Type Patches
Category Database
Status Unconfirmed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No

Details

This patch allows for the display id3 (v2.2-v2.4) tag
of Lyricist/Text writer in the wps, database, track info.

To display in wps, use "%iw" tag.

Example:
-----
# Disable Status Bar
%wd
# Title
%s%al%?it<%it|%fn>
# Artist
%s%al%?ia<%ia|%?d(2)<%d(2)|%(root%)>>
# Album
%s%al%?id<%id|%?d(1)<%d(1)|%(root%)>> %?iy<%(%iy%)|>
# Songwriter
%s%al%?iw<writer %iw|>
# Composer
%s%al%?ic<composer %ic|>
# Comment
%s%al%?iC<%iC|>
# Time PlayNumber
%al[%pc/%pt] %ar%(%pp/%pe%)
#%s%ac%Sx(Next:) %?It<%It|%Fn>
-----

Tested on sansa c200 v1.
Target source code revision is #29961.

The following files were changed:
apps/screens.c
apps/metadata/id3tags.c
apps/metadata/metadata_common.c
apps/lang/japanese.lang
apps/lang/english.lang
apps/gui/skin_engine/wps_debug.c
apps/gui/skin_engine/skin_tokens.c
apps/metadata.c
apps/metadata.h
apps/tagcache.c
apps/tagcache.h
apps/tagnavi.config
apps/tagtree.c
lib/skin_parser/tag_table.c
lib/skin_parser/tag_table.h

Currently, only English and Japanese languages are supported.

I am not good at English.
Please point it out if there are a problem.
   songwriter.29961.patch (17.1 KiB)
This task depends upon

Comment by PurlingNayuki (yzflcyq) - Saturday, 25 June 2011, 15:01 GMT
I don't think it's useful. Not all the MP3 file (Most of the MP3 files don't) contains those info.
Comment by Kaname Madoka (Lyrical Madoka) - Sunday, 03 July 2011, 16:45 GMT
I don't think so.
Songwriter, composer, and arranger are the basic information for pop songs.
If not contains those information in mp3 files, you can put it in.

Loading...