Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Drivers
  • Assigned To No-one
  • Operating System iPod 5G
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by cpu98 - 2011-06-12
Last edited by Buschel - 2011-06-20

FS#12154 - WM8758(iPod Video) driver according to datasheet

First patch does no fuctional change.

Added some comments to ease developing and removed nonfunctional features from header.
Whole datasheet is checked throughly.

   wm8758v1.diff (14.1 KiB)
Closed by  Buschel
2011-06-20 18:54
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Patches have been submitted with r30024 and r30025. Looking forward to see you working on the WM8975 :-)

cpu98 commented on 2011-06-12 11:34

corrected a typo

   00_wm8758_v2.diff (14.1 KiB)
cpu98 commented on 2011-06-12 14:12

Now here goes actual modifications.
You can expect better-than-OF quality.

http://imageshack.us/photo/my-images/860/rockbox.png/

   01_wm8758_v2.diff (2.1 KiB)
cpu98 commented on 2011-06-15 14:55

http://img204.imageshack.us/i/rockbox2.png/

Working on v4 now.
v3 has greatly reduced initial pop noise.

Tested with highly sensitive Sennheiser IE8.

Buschel commented on 2011-06-15 15:38

I just added  FS#10084  as related task (= bug report about popping noise at startup). I will try to shortly test this patch before the weekend and give feedback about the popping noise on my iPod.

Btw, is there any chance you could work on this for the iPod nano 2G as well? ;-) The iPod Video always sounded much better even w/o this patch.

cpu98 commented on 2011-06-15 15:44

Thanks.
v2 doesn’t remove popping noise.
I will upload v3 tomorrow.
Once I get this thing done I’ll look what I can do for wm8975.

Buschel commented on 2011-06-15 16:36

Great, I will use the next patch and give feedback then.

cpu98 commented on 2011-06-16 12:43

Notable differences against svn

1. Initial popping noise is reduced. (low imp, hi imp)
2. Sound quality better than RetailOS : Lower crosstalk, lower noise floor, lower HDs, lower IMD better SNR.
3. Thermal shutdown enabled to prevent iPod exploding. :)

   00_wm8758_v4_whitespace.diff (5.2 KiB)
   01_wm8758_v4_sheetmatching.di... (14.7 KiB)
   02_wm8758_v4_antipop+bettersq... (3.2 KiB)
saratoga commented on 2011-06-16 15:25

That looks like an unloaded RMAA test. You should try with a load, either headphones or at least a resistor to get a more realistic result. The output of the Video looks less impressive when its actually doing something :)

Buschel commented on 2011-06-19 13:26

I just tested your patch (v4) briefly. The popping noise during startup is drastically reduced. I could not hear any difference between svn and patched version when playing music (I didn’t expect to, but I wanted to make sure :).

+1 from me

saratoga commented on 2011-06-19 21:50

Looks good to me.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing