• Status Closed
  • Percent Complete
  • Task Type Bugs
  • Category FM Tuner
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.8.1
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by salaba - 2011-06-14
Last edited by jdgordon - 2011-06-16

FS#12158 - One menu item in radio not voiced


One menu item "Mode" (LANG_MODE) in radio submenu not voiced, other are voiced on same place. In this item is showing radio mode scan or present and also swithing it by this submenu item. I found that problem is in file \apps\menus\radio_menu.c in this part :

#ifndef FM_MODE
extern int radio_mode;
static char* get_mode_text(int selected_item, void * data, char *buffer)

  snprintf(buffer, MAX_PATH, "%s %s", str(LANG_MODE),
           radio_mode ? str(LANG_PRESET) :
  return buffer;

static int toggle_radio_mode(void)

  radio_mode = (radio_mode == RADIO_SCAN_MODE) ?
  return 0;


                               toggle_radio_mode, NULL, 
                               get_mode_text, NULL, NULL, NULL, Icon_NOICON);


Here isn't used ID2P.
Also for LANG_MODE will have add voice string to english.lang.

Please someone correct it.

Closed by  jdgordon
2011-06-16 13:28
Reason for closing:  Fixed
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407


This fixes it, annoingly LANG_MODE isnt voiced currently so unless you fix your language you might get nothing. (I've updated english.lang to deal with this. I dont know if this breaks things)

Hi Jonathan.
Much more thanks for your fast reaction, but I don't any possibility to test your patch - I can test only in daily builds.
Can you commint it and I just immediately test it. If it did not work so this could go back.


Available keyboard shortcuts


Task Details

Task Editing