Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Infrastructure → Build environment
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by torne - 2011-06-22
Last edited by kugel. - 2011-09-08

FS#12165 - Speed up genlang with a generated regex

With this change generating all languages takes only two-thirds the
time. It changes the acceptable syntax for target wildcards in language
files, however: instead of a comma-separated list of glob-style
wildcards it requires that it be a comma-separated list of prefix
matches, i.e. the * can only appear at the end of each wildcard, and ?
cannot be used. This does not require any changes to existing language
files as they are all already in this form.

Closed by  kugel.
2011-09-08 14:44
Reason for closing:  Accepted
Additional comments about closing:  

r30481

Another problem I spotted with genlang which leads to quite a speedup if fixed.

$BUILD/apps/lang/english.list is some cache file for the english strings. readenglish() is this cache file if it's newer than english.lang. The problem is the cache file is never updated after initial creation, so the fast path in readenglish() is only taken until english.lang is modified. I attach a patch to fix that, resulting in quite a speed up since the the fast path in readenglish() is taken.

Perhaps english.list should be generated via a make rule instead.

I'll add my +1 to both of these.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing