FS#12166 - Rbutil proxy settings cleared if password contains @

Attached to Project: Rockbox
Opened by Chris (akirhol) - Friday, 24 June 2011, 21:12 GMT
Last edited by Dominik Riebeling (bluebrother) - Saturday, 25 June 2011, 17:21 GMT
Task Type Bugs
Category Rbutil
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Rbutil 1.2.7
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No


What behaviour you are seeing:
- Proxy settings are cleared if an @ is used in the password

What behaviour you expected:
- Proxy settings saved and used properly

How to reproduce the bug:
- Specify proxy / port / username / password without @ symbol, works fine
- Add @ to the password and save, go back to proxy settings and everything is blank

This is in rbutil 1.2.10, there was no option to choose that instead of 1.2.7. Searched for anything relating to "proxy" and found no bugs detailing this issue.
This task depends upon

Closed by  Dominik Riebeling (bluebrother)
Saturday, 25 June 2011, 17:21 GMT
Reason for closing:  Fixed
Additional comments about closing:  should be ok in svn now, thanks for reporting.
Comment by Dominik Riebeling (bluebrother) - Saturday, 25 June 2011, 13:33 GMT
This is indeed a problem and caused by the configuration file storing the proxy configuration as string -- the values aren't lost, but restoring them fails because there is no way to separate them properly anymore. A similar issue appears when the password (or username) contains a colon.