- Status Closed
- Percent Complete
- Task Type Patches
- Category Codecs
- Assigned To No-one
- Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Daily build (which?)
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#12185 - Fix gapless playback for Nero AAC
This patch is fix to work gapless playback for AAC encoded by Nero AAC (Ver.1.3.3.0) and FAAC.
aac.patch
(1.2 KiB)
Closed by learman
2011-07-24 13:06
Reason for closing: Fixed
Additional comments about closing:
2011-07-24 13:06
Reason for closing: Fixed
Additional comments about closing:
Fixed in r30149.
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
Fix compile error.
Could you explain the patch a bit, please? To me it looks like it re-uses the lead_trim at the end of the file if no tail_trim has been specified, and that doesn’t look right (the MP4 container already allows the last frame to be properly trimmed, so it shouldn’t be necessary for FAAC/Nero at least).
I’m not sure.
But after r29727, unable gapless playback.
So I undid the point of deleted in r29727.
I have tested this file.
This file was encoded by FAAC and Nero 1.3.3.0.
Hm, yes, in the decode of test1_nero (using test_codec), there is a small piece of silence. Not much, 0.01s or so, and it is inaudible to me (the test track I used also get some silence, but only 0.003s). Foobar2000 does a good job, so there’s room for improvement. There’s got to be a better way though…
I see what you mean now. r29727 removed the last frame trimming used by FAAC/Nero files. I’ll commit a fix soon.
r30149 is very nice.
Sounds fine some test files.
Thanks.