Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Infrastructure → Build environment
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by wtachi - 2011-07-11
Last edited by thomasjfox - 2011-08-16

FS#12188 - Fix perl scripts that used Switch.

The recent Perl 5.14.0 release removed the Switch module. This patch replaces it with given/when (introduced more than three years ago).

   0001-Fix-perl-scripts-that-us... (4.4 KiB)
Closed by  thomasjfox
2011-08-16 19:30
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Accepted as r30323.

Thanks Nick! (also see r30324 ;))

nickp commented on 2011-07-19 04:59

Why not just use if/ elsif/ else? This would be compatible with all perl versions.

thomasjfox commented on 2011-08-13 17:16

Hmm, this change broke the Nokia N900/maemo 5 build: It’s stuck at perl 5.8.4.

What about the proposed change from Nick?

nickp commented on 2011-08-13 22:36

Here’s a patch using if/ elsif/ else.

   0002-Fix-perl-scripts-that-us... (8.8 KiB)
bluebrother commented on 2011-08-14 19:10

It might make sense to add a comment that tells why neither switch nor given/when is used. Apart from that I don’t see a reason against using if/elsif/else.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing