• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category ID3 / meta data
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.8.1
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Buschel - 2011-08-06
Last edited by Buschel - 2011-08-07

FS#12218 - embedded album art for ASF

The attached patch adds embedded album art for ASF. I am not 100% glad with the implementation as there ares till some magic numbers left. Also I cannot really test this on a large number of files with embedded jpg’s yet.
I would be glad to have some testers for this patch.

Closed by  Buschel
2011-08-07 15:27
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Submitted wit r30263.

This new version is more error resilient and avoids to use magic numbers especially for seeks. It also covers distinction between png and jpg (even though embedded png is generally not supported yet).
Last issue is that this will only work for embedded images smaller than 64 KB. Above this limit the ASF-tag is changing a lot and the detection of embedded images does not work.

Edit: Also updated the manual.


Available keyboard shortcuts


Task Details

Task Editing