• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category User Interface → Language
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by ukleinek - 2011-08-10
Last edited by bertrik - 2011-12-30

FS#12226 - several typo fixes

based on trunk@30268

Closed by  bertrik
2011-12-30 15:29
Reason for closing:  Wont Fix

While in general correct spelling in comments is a laudable goal, fixing spelling has to be weighted against other factors that may speak against touching the code in question at all: The code in question may be imported from a third party and eventually be rebased to a newer upstream version; or, the code may be actively worked on by another developer. In both cases, the spelling fixes create more work (rebasing) for very little benefit, which can be quite annoying. (The same can be said of whitespace fixes or code cleanups.)

Of the files touched by this patch, Doom, GNU chess, and some of the codec libraries belong to the first category; and I think at least elftosb belongs to the second.

Thus, I suggest to not blindly accept this patch, but to use pieces of it at an opportune time.

PS: Also, I don’t regard “thru” as a spelling error, especially not in informal code comments.


Available keyboard shortcuts


Task Details

Task Editing