Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Infrastructure → Build environment
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.9
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by nls - 2011-08-14
Last edited by nls - 2011-08-18

FS#12231 - Centralize codec compilation flag setting

This patch centralizes the selection of codec compilation flags to codec.make to avoid having to duplicate the per cpu selection logic and the build rule in the codec lib make files and make tweaking easier.

The two special cases, libamd and libspeex were left alone.

I plan to introduce a var for arm generation so that appropriate flags can be selected per generation as benchmarking results have shown that different arm arches might have different optimal flags.

Closed by  nls
2011-08-18 16:34
Reason for closing:  Accepted
Additional comments about closing:  

committed

Stupid question, but is it ok to do this:

$(A52LIB) : CODECFLAGS += -O1

$(A52LIB) : CODECFLAGS += -O2

I guess the last optimization flag is the one that sticks?

nls commented on 2011-08-16 14:31

Yes that is correct (CODECFLAGS already includes CFLAGS which contains the core -O switch too).

edit: from the gcc manual "If you use multiple -O options, with or without level numbers, the last such option is the one that is effective."

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing