Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category User Interface
  • Assigned To No-one
  • Operating System SW-codec
  • Severity High
  • Priority Low
  • Reported Version Release 3.9
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by MikeS - 2011-08-22
Last edited by kugel. - 2011-10-26

FS#12241 - Voice menus stop working after return to menu from recording screen

As the title suggests, voice menus cease to operate after using the recording screen. A reboot is required to restore voice menu functionality. I checked using r30339 on Gigabeat S and Sansa Fuze v2 thus suspect any SWCODEC target with recording would be affected. I do not at this point know which commit introduced the issue or if further voice issues exist.

Closed by  kugel.
2011-10-26 18:32
Reason for closing:  Fixed
Additional comments about closing:  

r30840

MikeS commented on 2011-08-23 23:22

Occasionally, it seems voice stops working altogether.

MikeS commented on 2011-08-25 00:08

Bwahahaha! I had english-us selected as the language instead of english, which was preventing voice working at all. However, the problem reported in this task is still valid.

MikeS commented on 2011-09-01 10:44

This seems to possibly affect anything calling talk_disable() to temporarily disable voice that grabs the audio buffer and actually uses it. The same happens with mpegplayer and rockdoom as with recording. Plugins that simply use plugin_get_audio_buffer to stop audio along with talk_disable to disable voice appear not to affect anything.

Is talk_disable even needed any more or was it required merely due to some shared resource? It was (effectively) introduced in r10789, but I don't understand the comment " /* recording_menu gets messed up: so reset talk_menu */" .

MikeS commented on 2011-09-02 10:53

It is still needed at this point to keep voice from using stolen buffer space that isn't valid to use.

Ah, I'd assumed the buflib mods had sorted that one out…

MikeS commented on 2011-09-02 14:05

Things in that area haven't yet been converted everywhere they could be.

I could reproduce on the sim after adding the pcm_rec_init() call to the sim's main(). Will have a look later, but my suspicion is that voice isn't properly re-initialized after a audio_get_buffer() call.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing