Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category Music playback
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.9
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Nick Peskett - 2011-08-26
Last edited by Andree Buschmann - 2011-08-26

FS#12246 - Progress bar cuesheet markers wrap with long audio files.

When playing a file longer than around 6 hours with cuesheet support enabled, cues > around 6 hours cause long unsigned multiplication overflows, making the marker x offset wrap back to the start of the progress bar.

To reproduce:

Enable Settings > Playback Settings > Cuesheet Support.
Generate mp3 & cue using attached perl script.
There ought to be 10 evenly spaced cues, but they start wrapping after the sixth.

Solution (attached):

Cast the cue offset as a long long when performing the multiplication.

Closed by  Andree Buschmann
2011-08-26 15:52
Reason for closing:  Accepted
Additional comments about closing:  

Submitted with r30359.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing