• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category Games
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.9
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by v4hn - 2011-09-03
Last edited by nls - 2011-09-08

FS#12257 - Goban mixes up stone colors on inverse displays

As the summary states the goban code doesn’t consider,
whether the foreground color of the display is bright or dark.
This results in black playing first with white stones on some sansa players.

The attached patch distingishs between SANSA_CLIP/SANSA_CLIPV2/SANSA_CLIPPLUS
and everything else, as those are the only players with bright foreground I found.

Tested with a couple of different simulators and on Clip+.

Closed by  nls
2011-09-08 12:44
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

committed, thanks

nls commented on 2011-09-04 11:52

we have a #define for such displays, HAVE_NEGATIVE_LCD it’s better to test for that as it covers one more such target, the mrobe 100

v4hn commented on 2011-09-04 12:48

Thanks, I looked for such a constant, but didn’t find it..
The updated patch it attached.


Available keyboard shortcuts


Task Details

Task Editing