FS#12257 : Goban mixes up stone colors on inverse displays

Status Closed
Percent Complete
100%
Task Type Patches
Category Games
Assigned To No-one
Operating System All players
Severity Low
Priority Very Low
Reported Version Release 3.9
Due in Version Undecided
Due Date Undecided
Votes
Private

Attached to Project: Rockbox
Opened by v4hn - 2011-09-03
Last edited by nls - 2011-09-08

FS#12257 - Goban mixes up stone colors on inverse displays

As the summary states the goban code doesn’t consider,
whether the foreground color of the display is bright or dark.
This results in black playing first with white stones on some sansa players.

The attached patch distingishs between SANSA_CLIP/SANSA_CLIPV2/SANSA_CLIPPLUS
and everything else, as those are the only players with bright foreground I found.

Tested with a couple of different simulators and on Clip+.

rockbox-fix_sansa_goban_color... (1.5 KiB)

Closed by nls
2011-09-08 12:44
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

committed, thanks