Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Infrastructure → Build environment
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.9
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Buschel - 2011-09-03
Last edited by Buschel - 2011-09-07

FS#12258 - Do not use -ffunction-sections -fdata-sections for mingw builds

The attached patch changes the makefiles for plugins, codeclibs and codecs/lib/tlsf to not use ‘-ffunction-sections’ and ‘-fdata-sections’ for simulator builds. This removes several warnings when compiling in my environment (Ubuntu + mingw32).

This needs a review, I am not sure whether I am detecting simulator builds 100% right via “ifdef APP_TYPE”.

   make_v01.patch (2.5 KiB)
Closed by  Buschel
2011-09-07 19:25
Reason for closing:  Accepted
Additional comments about closing:  

Submitted with r30468.

Buschel commented on 2011-09-04 08:30

The new version checks whether a mingw cross compiler is used. In this case '-ffunction-sections' and '-fdata-sections' is not used.

   make_v02.patch (2.6 KiB)
Buschel commented on 2011-09-07 18:35

'-ffunction-sections' and '-fdata-sections' should be not used for cygwin as well. Therefor check for "sdl-sim".

   make_v03.patch (2.6 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing