• Status Closed
  • Percent Complete
  • Task Type Bugs
  • Category Infrastructure → Build environment
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by pondlife - 2011-09-06
Last edited by Buschel - 2011-09-07

FS#12261 - -fgnu89-inline breaks Cygwin build

r30420 added -fgnu89-inline to the doom and mpegplayer makefiles, this isn’t supported on Cygwin (gcc 3.4.4).

I’m not big on makefiles, so am not sure what a suitable test would be - i.e. how to detect gcc 3.x.

Closed by  Buschel
2011-09-07 18:37
Reason for closing:  Fixed
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Submitted with r30467.

I reworked this a bit. “-fgnu89-inline” was introduced with GCC 4.1.3 (=GCCNUM 401). The attached only sets “-fgnu89-inline” if GCCNUM >= 401 is true. This compiles now for cygwin simulator (GCC 3.0.4), cygwin target (4.4.4), my Ubuntu mingw32 simulator (GCC 4.2.1) and Ubuntu target (GCC 4.4.4) w/o the “gnu89 inline” warnings.

Yup, fixit if for me - thanks.

Oops, mobile keyboard wrongness, hope you understood!


Available keyboard shortcuts


Task Details

Task Editing