Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface → Language
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by rbbrittain - 2011-09-10
Last edited by fg - 2011-09-13

FS#12269 - Add "USB Hide Internal Drive" to english-us.lang

I've been using Rockbox for years on my Sansa e380 (v1), but I'm a noob at modern-day code-writing. (To show you how old my skills are, my last formal training was in college–in languages like Cobol, Fortran & IBM assembler. ;) ) I just installed the Ubuntu VirtualBox image as my development environment within the last week and managed to compile a couple of SVN updates.

Nonetheless, I have a very simple patch for a first-timer that should be easy to commit: Add the "USB Hide Internal Drive" phrase to english-us.lang. Since english-us is just a minor patch job on english.lang (replace "colour" with "color", etc.) and had no issues before that phrase was added, and the new phrase is just fine in American English, this should be a no-brainer for anyone who can commit it.

To be safe, I did use genlang to create it from the current SVN files, even though it's really a simple cut-and-paste job; all I had to do to new-english-us.lang after that was remove the comments genlang inserted with the new phrase.

Thanks in advance!

Closed by  fg
2011-09-13 19:21
Reason for closing:  Accepted
Additional comments about closing:  

Thanks, committed as r30517

As a note for future contributions, patches are easier to work with than the entire file.

Just built & installed r30494 with this patch on my e280; everything seems OK. New command shows up under Settings > General Settings > System. Should be OK to commit.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing