Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category User Interface
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by fg - 2011-09-24
Last edited by jdgordon - 2011-09-25

FS#12289 - Skin comments take up space in the skin buffer

At least in r30593 wps, sbs and fms comment lines seem to be stored in the skin buffer.

My testing used iLike for nano, on a sim. This theme uses 88K of skin buffer (more than the default allowance, I had to bump WPS_MAX_TOKENS a bit). Stripping comment lines reduces that to 63.7K. The comment lines take about 25513 bytes in the files, which is (almost?) exactly the difference.

Closed by  jdgordon
2011-09-25 13:03
Reason for closing:  Fixed
jdgordon commented on 2011-09-25 02:56

I have no idea what’s happening here! The comments are not being stored on the skin buffer (see libs/skin_parser/skin_parser.c skin_parse_comment() ) so I thught prehaps it is just allocating a LINE element for each one, but that doesnt seem to be happening according to the checkwps output (and elements are we’d need a few hundred to fill the buffer). But I can confirm that manually skipping leading comments at the begingin of the file does partially solve it, so there definitly is a bug (of course [saint]’s comment style can be said ot be broken also :) )

investigating

jdgordon commented on 2011-09-25 03:20

err, that may actually be it.. the wps is doing 24KB of just skin_element structs, most being empty

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing