FS#1232 - %ig returns default value for unrecognized tags

Attached to Project: Rockbox
Opened by Vincent Kargatis (kargatis) - Friday, 18 April 2003, 18:28 GMT
Last edited by Daniel Stenberg (bagder) - Friday, 05 December 2003, 09:22 GMT
Task Type Bugs
Category User Interface
Status Closed
Assigned To No-one
Operating System
Severity Low
Priority Normal
Reported Version Release 2.0
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


When the code doesn't recognize an ID3 genre (a free-
text genre value, for instance), it seems to return a
default value of 'Blues', rather than NULL, which it did
before, and which was acceptable (one could test on it
in their WPS cfg). But a default value is silly - it's going
to be frequently wrong no matter what. Please return
the NULL value when the genre isn't recognized.

(It may be that there's some other twist going on - the
symptoms are that files where %ig used to be null are
now showing 'Blues', fwiw.)
This task depends upon

Closed by  Daniel Stenberg (bagder)
Friday, 05 December 2003, 09:22 GMT
Reason for closing:  Fixed
Comment by Vincent Kargatis (kargatis) - Wednesday, 14 May 2003, 20:54 GMT

Hint for future fix, from Bjorn in chat:
<Zagor> [...] try simply initializing entry->genre to 0xff in

[right now it's initialized to '0' - changed in ver168 - which
would explain the problem. See comment for ver165 :-]

(I'm not a C coder and do not want to mess with the code.
I'm just posting this for handy reference and a hopefully quick
and easy remedy)
Comment by Vincent Kargatis (kargatis) - Friday, 18 July 2003, 11:38 GMT

This is fixed in CVS.