Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category User Interface
  • Assigned To No-one
  • Operating System
  • Severity Low
  • Priority Very Low
  • Reported Version Release 2.0
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by kargatis - 2003-04-18
Last edited by bagder - 2003-12-05

FS#1232 - %ig returns default value for unrecognized tags

When the code doesn't recognize an ID3 genre (a free-
text genre value, for instance), it seems to return a
default value of 'Blues', rather than NULL, which it did
before, and which was acceptable (one could test on it
in their WPS cfg). But a default value is silly - it's going
to be frequently wrong no matter what. Please return
the NULL value when the genre isn't recognized.

(It may be that there's some other twist going on - the
symptoms are that files where %ig used to be null are
now showing 'Blues', fwiw.)

Closed by  bagder
2003-12-05 09:22
Reason for closing:  Fixed
kargatis commented on 2003-05-14 20:54

Hint for future fix, from Bjorn in chat:
<Zagor> […] try simply initializing entry→genre to 0xff in
firmware/id3.c:264

[right now it's initialized to '0' - changed in ver168 - which
would explain the problem. See comment for ver165 :-]

(I'm not a C coder and do not want to mess with the code.
I'm just posting this for handy reference and a hopefully quick
and easy remedy)

kargatis commented on 2003-07-18 11:38

This is fixed in CVS.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing