FS#12323 : Touchscreen: Show line separator in lists

Status Closed
Percent Complete
100%
Task Type Patches
Category User Interface
Assigned To

kugel.
Operating System All players
Severity Low
Priority Very Low
Reported Version Release 3.9
Due in Version Undecided
Due Date Undecided
Votes
Private

Attached to Project: Rockbox
Opened by kugel. - 2011-10-07
Last edited by kugel. - 2013-01-18

FS#12323 - Touchscreen: Show line separator in lists

This patch adds the ability to show a horizontal line separator in lists, as a visual indicator for the list lines.

It’s configurable in the theme menus, where it can be enabled and its color be changed.

As this is a theme setting, cabbiev2 is updated to include this setting. I think it includes it on all targets because I don’t think wpsbuild has the magic to make stuff touchscreen specific.

Apply ~~FS#12321~~ before this.

list-line-sep-1.patch (7.9 KiB)

Closed by kugel.
2013-01-18 17:09
Reason for closing: Not a Bug
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407 Warning: Undefined array key "useheading" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 1099 Warning: Undefined array key "target" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557 Warning: Trying to access array offset on value of type null in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557

http://gerrit.rockbox.org /384

Comments (1)
Related Tasks (0/0)

jdgordon commented on 2011-10-08 13:37

another very wrong patch. this adds nothing that isnt already possible in the theme engine. And worse, it adds alot of cruft (voice+settings) for the majority of people who dont want and will never use it.
granted there is no skin tag to draw a horizontal line (though that was something I wanted to do for a while) doing that would be much smaller and less bloat for everyone else

	Tasks related to this task (0)

Loading...

Keyboard shortcuts

Available keyboard shortcuts

Alt + ⇧ Shift + l Login Dialog / Logout
Alt + ⇧ Shift + a Add new task
Alt + ⇧ Shift + m My searches
Alt + ⇧ Shift + t focus taskid search

Tasklist

o open selected task
j move cursor down
k move cursor up

Task Details

n Next task
p Previous task
Alt + ⇧ Shift + e ↵ Enter Edit this task
Alt + ⇧ Shift + w watch task
Alt + ⇧ Shift + y Close Task

Task Editing

Alt + ⇧ Shift + s save task