• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category Settings
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by anotherche - 2011-10-27
Last edited by speachy - 2019-02-03

FS#12353 - Improvement of the car adapter mode

Default delay before resume on power coming back used in rockbox (5 sec) is not always sufficient for a car audio head unit to finish the startup procedure.
1. The patch adds the menu setting to configure the delay in the range 5 to 30 seconds in 5 sec step.
2. Original car adapter mode processing doesn’t distinguish if audio was paused due to power outage or by hand, so it resumes in any case on power coming back. The patch handles manual pause so that paused state is preserved on the power change.
3. The last, if user intervenes in playback control during delay-before-resume time interval the car adapter mode processing doesn’t try to resume with this patch.

The patch is for r29795

Closed by  speachy
2019-02-03 22:39
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

I just merged an updated version of this patch. I have a car which 5s is not enough, and another which 5s is plenty…

How long does your car need? I think 5 seconds is pretty short, maybe we should just increase it a little in case other people have this problem as well.

In my car it can take up to ~15 sec. I understand that it’s not desirable to increase the number of settings and weight of the rockbox code. But I believe that there are cases when 5 sec is just fine and cases when 30 sec is necessary. What are you thinking about two other options? The second requires an additional variable only, and I found it to be very useful. The third requires one if() only and makes the mode just more controllable.


Available keyboard shortcuts


Task Details

Task Editing