• Status Closed
  • Percent Complete
  • Task Type Bugs
  • Category Music playback
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.9
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by MarcinBukat - 2011-10-28
Last edited by MikeS - 2011-10-29

FS#12356 - next track advances when skip in repeat one mode

Way to reproduce:
1) select file from file browser
2) change repeat to ‘one’ 3) skip doesn’t change the file (that is expected) but next track displayed in WPS advances

Closed by  MikeS
2011-10-29 20:43
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Patch commed in r30857

For me (on RaaA), skip does change the file. Then the WPS plays track 2, and shows track 3 as next track. Skipping again goes back to the selected file (track 1).

MikeS commented on 2011-10-28 13:23

I’m not personally observing this yet but I can only see playback getting different files if in fact the playlist give the playback engine another path. Repeat One should result in the engine seeing the same path over and over again in an endless loop.

MikeS commented on 2011-10-28 13:25

One possibility comes to mind, that if this happens only going from “none” to “one” then a proper flush and reload of the playlist isn’t happening in some cases.

My case is when going from none to one

I can see wodz’ behavior when going from repeat all to one.

MikeS commented on 2011-10-29 18:27

From which screen is repeat mode being changed? I see the quickscreen calls audio_flush_and_reload_tracks. Perhaps that call is missing elsewhere.

MikeS commented on 2011-10-29 19:12

I tried from the playback menu and of course it didn’t have the needed call. These complex settings should be done through a single call that handles the change properly as is done with cuesheets and crossfade.

So, here’s a patch that takes care of that. Enlighten me of more places repeat_mode gets changed that I might have missed.

You can change settings in skins with some tag. I don’t know where/how it’s implemented, though.

MikeS commented on 2011-10-29 19:21

Ah, thanks. It turns out that one has the needed call.

Repeat mode touchregion seems also fine

MikeS commented on 2011-10-29 19:50

Ought I commit this? I saw the reported behavior without it and it did the trick to resync playback in the menu case.

Looks good to me


Available keyboard shortcuts


Task Details

Task Editing