Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Thomas Martitz - 2011-10-30
Last edited by Thomas Martitz - 2011-12-22

FS#12358 - Support for transparency in 32bit Bitmaps

The second patch adds the ability to read and use alpha channel information in 32bit bitmaps. The font drawing function is re-used to enable alpha blending. I tested it with BMPs created by imagemagick and gimp, it’s so far enabled for iconsets and skin engine (I don’t think it works with resizing, so no support for it in album arts).

The first patch adds two APIs, lcd_bmp() and lcd_bmp_part() and is required for the second. It’ll most probably committed anyway. It simplifies drawing bitmaps that come out of read_bmp_fd/_file.

Please give it a test and comment. I attach also 3 iconsets for testing. I tested in a few sims (e200, h300, h100, mr500) and RaaA so far.

Closed by  Thomas Martitz
2011-12-22 15:56
Reason for closing:  Accepted
Additional comments about closing:  

r30937

Thomas Martitz commented on 2011-11-02 20:16
Boris Gjenero commented on 2011-11-10 00:53

In r30944 I was getting crashes at “*bm_alpha = alpha┬╗4;”, just below the “pack alpha channel for 2 pixels into 1 byte” comment. Playback would start reliably, but skipping a bunch of tracks led to the crash. In r30948 I set alpha_offset to zero when loading a JPEG. This fixes the problem.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing