Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category User Interface → Themes
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by zhkailing - 2011-11-08
Last edited by freddyb - 2011-11-10

FS#12374 - r30932 may bring back font issues related to FS#12306 & FS#12336.

The modifications in font.h & font.c reintroduce font issues.
It may be related to  FS#12306  &  FS#12336 .

Closed by  freddyb
2011-11-10 14:08
Reason for closing:  Fixed
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Fixed in r30932. Hopefully, that's the last reference to FONT_UI, which is now deprecated.

kugel. commented on 2011-11-08 14:18

Can you please be more specific? What change exactly?

zhkailing commented on 2011-11-08 14:23

Is it necessary to upgrade some plugins such as lrcplayer for the disuse of FONT_UI ?

zhkailing commented on 2011-11-08 14:27

I means that the bugs in  FS#12306  and  FS#12336  are reproduced now.

freddyb commented on 2011-11-08 23:17

It looks like lrcplayer wasn’t updated. I couldn’t reproduce the keyboard problem.

   lrcplayer.patch (1.4 KiB)
jdgordon commented on 2011-11-08 23:25

Thanks Fred, I’ll commit this tonight if you don’t get to it first

freddyb commented on 2011-11-08 23:41

That’s fine.

freddyb commented on 2011-11-10 02:54

zhkailing, do you still have any issues after r30932?

zhkailing commented on 2011-11-10 06:31

lrcplayer is OK，thanks.
But It would seem that the latest rockbox doesn’t support some 32-bit Bmps（Can be read, but not displayed properly）. If I convert it to 24-bit, the theme returns to normal.

   example.zip (17.5 KiB)
kugel. commented on 2011-11-10 09:07

What program did you create that file with?

Bitmap contains alpha information (all zeros, though). Zero is considered entirely transparent as of recently that’s why it’s not displayed. Re-saving the file in gimp makes that zeros all 255s (0xff) which is entirely opaque and displayed correctly.

So not displaying it is correct considering our definition of transparency in 32bit bitmaps. Considering that, though, it’s curious why there’s slight garbage at the edges.

kugel. commented on 2011-11-10 09:10

Gimp displays the image correctly though. Unless you exchange a single 0×00 with 0xff, then it displays it transparent. So it seems to detect the all-zeros magic for non-transparency.

freddyb commented on 2011-11-10 12:55

I’m going to close this unless there are other font issues.

zhkailing commented on 2011-11-10 13:26

OK .

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing