Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category ID3 / meta data
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.9
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by nickp - 2011-12-01
Last edited by nickp - 2011-12-16

FS#12419 - Support for embedded cuesheets.

This patch adds the ability for a cuesheet to be embedded within a tag of an audio file, and to be read directly from there.

Currently only the ID3v2 TXXX:CUESHEET tag is supported, but I plan to look into FLAC next.

   embedded_cuesheets_31089.patch (10.8 KiB)
Closed by  nickp
2011-12-16 10:50
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Submitted with r31321 and r31322.

nickp commented on 2011-12-01 10:48
Warning: Undefined array key "useheading" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 1099 Warning: Undefined array key "target" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557 Warning: Trying to access array offset on value of type null in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557

I’ve attached a perl script to generate a little test mp3 to demonstrate the patch. You’ll need the CPAN MP3::Tag module installed to run it (Debian package libmp3-tag-perl).

Alternatively, you can use eyeD3 (package eyed3 or http://eyed3.nicfit.net/) to attach an existing cuesheet to a corresponding mp3 file;

eyeD3 –set-user-text-frame=”CUESHEET:`cat example.cue`” example.mp3

   make_test_mp3.pl (1.1 KiB)
nickp commented on 2011-12-03 01:55

Added support for FLAC with cuesheet embedded using –tag-from-file, e.g.;

flac –tag-from-file=”CUESHEET=example.cue” example.wav -o example.flac

   embedded_cuesheets_31113.patch (11.6 KiB)
nickp commented on 2011-12-13 09:27

Added a manual entry.

   embedded_cuesheets_31228.patch (12.7 KiB)
nickp commented on 2011-12-13 09:31

To encode Ogg Vorbis or Speex;

oggenc -c “CUESHEET=`cat example.cue`” example.wav -o example.ogg

speexenc –comment “CUESHEET=`cat example.cue`” example.wav example.spx

nickp commented on 2011-12-13 10:55

Vorbis comments now default to utf8 encoding.

   embedded_cuesheets_31228_utf8... (12.9 KiB)
nickp commented on 2011-12-14 15:13

Support for character encoded ID3 tags and UTF-16

   embedded_cuesheets_31247.patch (14.9 KiB)
nickp commented on 2011-12-16 09:18

Tidied and now doing more secure BOM checking.

   embedded_cuesheets_31320.patch (14.8 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing