FS#12421 - RaaA: Enable assembler optimized PCM mixer routines
Attached to Project:
Rockbox
Opened by Thomas Jarosch (thomasjfox) - Thursday, 01 December 2011, 21:06 GMT
Last edited by Thomas Martitz (kugel.) - Friday, 03 February 2012, 20:59 GMT
Opened by Thomas Jarosch (thomasjfox) - Thursday, 01 December 2011, 21:06 GMT
Last edited by Thomas Martitz (kugel.) - Friday, 03 February 2012, 20:59 GMT
|
DetailsHi,
attached patch enables assembler optimized PCM mixer routines for RaaA. This fixes r30099. @kugel: Is it ok to add "target/arm" to the include path on android? Cheers, Thomas |
This task depends upon
Closed by Thomas Martitz (kugel.)
Friday, 03 February 2012, 20:59 GMT
Reason for closing: Out of Date
Additional comments about closing: firmware has now the asm folder which selects optimized asm regardless of native/hosted.
Friday, 03 February 2012, 20:59 GMT
Reason for closing: Out of Date
Additional comments about closing: firmware has now the asm folder which selects optimized asm regardless of native/hosted.
That was my feeling, too.
We could either move the files directly next to "firmware/pcm_mixer.c" or
stuff them into a "firmware/target/pcm_mixer/" directory.
I'd rather avoid to hardcode the path like "../arm/foo".
Any preference?
How about firmware/target/(one of:arm,coldfire,sh,mips)/common? Or firmware/arch/(one of:arm,coldfire,sh,mips)/<filename>?
There is DSP code that could also benefit from an app-level tree.
ETA: how to make a subdir for PortalPlayer would sort of resolve itself.
Also require a C equivalent for each asm implementation in that directory.
How about "firmware/target/generic_asm" or "firmware/target/optimized"?