Rockbox

Attached to Project: Rockbox
Opened by dreamlayers - 2011-12-01
Last edited by dreamlayers - 2011-12-06

To reproduce, ensure car adapter mode is enabled, start playback, and leave the now playing screen. If the charger isn't connected, connect it now. Then, disconnect the charger, causing a car adapter mode pause. Some parts of the now playing screen will overwrite the current screen. I see this in file view, main menu and settings. The main menu is quickly redrawn and back to normal, but the file view is only redrawn after I do something. Now, reconnect the charger, which causes a car adapter mode unpause after a short delay. The same thing happens.

I've seen this on:
- 5G iPod using Firewire power, running 3.10RC and r31106
- Archos Recorder V2 using charger, running 3.10RC and r31106

Edit: The same thing happens with headphone plug-in unpause (but not headphone unplug pause). I expect the problem also happens when using BUTTON_MULTIMEDIA_PLAYPAUSE, but I did not test that.

The problem is due to the pause_action() and unpause_action() calls in apps/misc.c. The second parameter is "bool updatewps". It is true in all cases except headphone unplug pause. I don't know why it's false in that particular case.

The second parameter probably shouldn't be there. The WPS should simply update itself if it is currently displayed.